Skip to content

Fix response headers usage with upcoming node changes #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mscdex wants to merge 1 commit into from
Closed

Fix response headers usage with upcoming node changes #3174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lib/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,22 @@ defineGetter(req, 'fresh', function(){

// 2xx or 304 as per rfc2616 14.26
if ((s >= 200 && s < 300) || 304 === s) {
return fresh(this.headers, (this.res._headers || {}));
var resHeaders = this.res._headers || {};

// Support changes in node with how response headers are stored
var headerNames = this.res._headerNames || {};
var keys = Object.keys(resHeaders);
if (keys.length > 0 && headerNames[keys[0]] === undefined) {
Copy link
Contributor

@dougwilson dougwilson Jan 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a whole lot of Node.js http mock libraries out there (https://github.com/howardabrams/node-mocks-http comes to mind) and they have never mocked the _headerNames object. I think this would cause the usage of those modules to change the behavior (probably break) people's tests for Express projects that use them since this code would detect those mocks as the new style of headers and then copy all the header values as undefined, right?

var oldResHeaders = {};
for (var i = 0; i < keys.length; ++i) {
var key = keys[i];
// resHeaders[key] === [originalCasedKey, value]
oldResHeaders[key] = resHeaders[key][1];
}
resHeaders = oldResHeaders;
}

return fresh(this.headers, resHeaders);
}

return false;
Expand Down