Stabilize the identity of the Provider value #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Jan 10, 2022
# [3.13.0](v3.12.0...v3.13.0) (2022-01-10) ### Bug Fixes * defer calling onSelect until after animation ([#248](#248)) ([1fb3411](1fb3411)), closes [#203](#203) * stabilize the identity of the context provider value ([#251](#251)) ([55005ba](55005ba)) ### Features * support closing actionsheet with Esc key on web ([#247](#247)) ([c4c3f8b](c4c3f8b)), closes [#194](#194)
Contributor
|
🎉 This PR is included in version 3.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
robertomartinez09515
added a commit
to robertomartinez09515/action-sheet-react-best-proj
that referenced
this pull request
Jul 25, 2022
# [3.13.0](expo/react-native-action-sheet@v3.12.0...v3.13.0) (2022-01-10) ### Bug Fixes * defer calling onSelect until after animation ([#248](expo/react-native-action-sheet#248)) ([1fb3411](expo/react-native-action-sheet@1fb3411)), closes [#203](expo/react-native-action-sheet#203) * stabilize the identity of the context provider value ([#251](expo/react-native-action-sheet#251)) ([55005ba](expo/react-native-action-sheet@55005ba)) ### Features * support closing actionsheet with Esc key on web ([#247](expo/react-native-action-sheet#247)) ([c4c3f8b](expo/react-native-action-sheet@c4c3f8b)), closes [#194](expo/react-native-action-sheet#194)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Object that is passed into the
valueprop of the provider is generated on each render. This causes each subscriber ofuseActionSheetto re-render, unnecessarily.This can also cause issues for any dependency arrays or PureComponents that are including
showActionSheetWithOptions.This PR will stabilize the identity of the
value, so it won't change.I'm not sure if the
getContextfunction is necessary. I kept it in there in case it's being used somewhere that I can't see.