Skip to content

get_array_module with non-array input returns None #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianeboyd merged 8 commits into from
Jul 7, 2022
Merged

get_array_module with non-array input returns None #703

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
134de83
if not xp array module is None
kadarakos Jun 17, 2022
ea24ce5
raise error
kadarakos Jun 20, 2022
be9d18c
update test
kadarakos Jun 20, 2022
b78182f
more detailed error
kadarakos Jun 20, 2022
f27a59c
Update thinc/tests/test_util.py
kadarakos Jun 23, 2022
f49eefb
Merge branch 'master' into get-array-module-fix
svlandeg Jun 29, 2022
f22cbdd
Update thinc/util.py
kadarakos Jul 6, 2022
917731f
Update thinc/tests/test_util.py
adrianeboyd Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions thinc/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,12 @@ def get_torch_default_device() -> "torch.device":


def get_array_module(arr): # pragma: no cover
if is_cupy_array(arr):
if is_numpy_array(arr):
return numpy
elif is_cupy_array(arr):
return cupy
else:
return numpy
return None


def gpu_is_available():
Expand Down