Backport fixes from master to v8.0.x
#662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tests: Correctly handle GPU-resident Tensorflow tensors * Simplify `is_supported_backend_array`
danieldk
reviewed
May 12, 2022
* `CupyOps`: Simplify `asarray` * Remove `cast_array` flag and use `astype` unconditionally * Revert unconditional call to `astype` * Remove no-op
* `NumpyOps`: Better type-casting in `asarray` * Simplify `dtype` check * Update thinc/backends/numpy_ops.pyx Co-authored-by: Adriane Boyd <[email protected]> * Simplify casting further, avoid copies if possible * Remove no-op Co-authored-by: Adriane Boyd <[email protected]>
Contributor
|
I suppose this can be taken out of WIP? |
Contributor
Author
|
@explosion-bot please test_gpu |
Collaborator
URL: https://buildkite.com/explosion-ai/thinc-gpu-test-suite/builds/65 |
* Fix out-of-bounds writes in NumpyOps/CupyOps
- Using `{CupyOps,NumpyOps}.adam` with incompatible shapes for weights,
gradients, or moments resulted in out-of-bound writes.
- Using `NumpyOps.adam` with non-float32 arrays resulted filling arrays
with incorrect data.
* Remove print debugging remnants
Co-authored-by: Adriane Boyd <[email protected]>
* More print debugging remnants
Co-authored-by: Adriane Boyd <[email protected]>
Co-authored-by: Adriane Boyd <[email protected]>
Contributor
|
@explosion-bot please test_gpu |
Collaborator
URL: https://buildkite.com/explosion-ai/thinc-gpu-test-suite/builds/66 |
Contributor
|
Added #664. |
svlandeg
approved these changes
May 18, 2022
danieldk
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
The following PRs need to be merged into
masterand then cherry-picked into this branch.CupyOps: Simplifyasarray#661asarray#656