Allow blis v0.9.x #658
Closed
Allow blis v0.9.x #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@explosion-bot please test_gpu |
Collaborator
URL: https://buildkite.com/explosion-ai/thinc-gpu-test-suite/builds/62 |
danieldk
reviewed
May 10, 2022
| cymem>=2.0.2,<2.1.0 | ||
| preshed>=3.0.2,<3.1.0 | ||
| blis>=0.4.0,<0.8.0 | ||
| blis>=0.4.0,<0.10.0 |
Contributor
There was a problem hiding this comment.
We should require 0.9.0 for #643. I already added commit there that changes the requirements.
Contributor
Author
There was a problem hiding this comment.
Okay, this was mainly as a sanity check for the release. We can merge this (but it wouldn't affect much) or just wait until that PR is ready.
Contributor
|
#643 got merged so closing this one :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.