Skip to content

Conversation

@danieldk
Copy link
Contributor

@danieldk danieldk commented Jan 17, 2022

...to avoid many small GPU <-> CPU transfers.

I still have to benchmark this change to see if this leads to a meaningful training time difference.

...to avoid many small GPU <-> CPU transfers.
@danieldk danieldk requested a review from honnibal January 17, 2022 08:47
@danieldk
Copy link
Contributor Author

@explosion-bot please test_gpu

@explosion-bot
Copy link
Collaborator

explosion-bot commented Jan 17, 2022

🪁 Successfully triggered build on Buildkite

URL: https://buildkite.com/explosion-ai/thinc-gpu-test-suite/builds/15

@danieldk danieldk marked this pull request as draft January 17, 2022 10:06
@danieldk danieldk marked this pull request as ready for review January 17, 2022 10:31
@danieldk danieldk force-pushed the unflatten-dont-loop branch from 298489f to ba295da Compare January 17, 2022 10:55
@danieldk danieldk force-pushed the unflatten-dont-loop branch from ba295da to fcc572c Compare January 17, 2022 11:27
@svlandeg svlandeg added enhancement Feature requests and improvements feat / ops Backends and maths performance Speed and memory use labels Jan 17, 2022
@svlandeg
Copy link
Contributor

svlandeg commented Jan 20, 2022

@danieldk : looks good! Feel free to merge in once you're done with your benchmarks and everything seems OK :-)

@danieldk
Copy link
Contributor Author

Just a status update: I want to benchmark this a little more.

@danieldk danieldk marked this pull request as draft January 27, 2022 07:47
@danieldk
Copy link
Contributor Author

I did more benchmarks and this change seems to make training slightly slower (2-3%) and inference slightly faster by the same amount. Since a declarative style is nicer in general and since this should scale better (the looping over the array will get more expensive with longer lengths arrays), I'll merge this.

@danieldk danieldk marked this pull request as ready for review March 30, 2022 13:46
@danieldk danieldk merged commit 58f50aa into explosion:master Mar 30, 2022
@danieldk danieldk deleted the unflatten-dont-loop branch March 30, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature requests and improvements feat / ops Backends and maths performance Speed and memory use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants