-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Displacy serve entity linking support without manual=True support.
#9748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displacy serve entity linking support without manual=True support.
#9748
Conversation
… support is only limited to the manual option in displacy.render
svlandeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, much appreciated! Also good to see an additional test for the new functionality. I had just a few small comments.
Co-authored-by: Sofie Van Landeghem <[email protected]>
|
Looks good to me, just want to run this by @ines as well :-) |
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
ines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks good 🎉 And really appreciate the test and docs update!
The PR adds support for visualizing kb_id on entities when run via displacy.serve
Description
The PR adds support for visualizing kb_id on entities when run via displacy.serve. The recent changes from PR 9199 only address rendered html produced with the
manual=Trueoption set. I believe the same should also be afforded when passingDocobjects with entities that have thekb_idset.For the
kb_urlto be set, one can pass thekb_url_format_template(can be named better?) in theoptionsargument ofdisplace.serve. If not set,kb_urldefaults to#similar to the setting in the above linked PR. Please suggest if there is a better way to do this.Types of change
Enhancement
Checklist