Skip to content

Conversation

@filipecaixeta
Copy link
Contributor

Description

bug fix / enhancement

  • The previous tokenizer splits on hyphen. That was a problem because there are many words in Portuguese written with hyphen.
    micro-ondas (microwave), guarda-chuva (umbrella)
  • Added currency symbol from Brazil (R$), including the old currency (Cz$, NCz$)
  • Removed some stop words that sholdn't be there. Noite (night), viagem (trip), trabalhar (to work) and others.
  • Included some stop words
  • Fix like_num for numbers like 1º (1st)

@ines ines added enhancement Feature requests and improvements lang / pt Portuguese language data and models labels Sep 22, 2018
@defijesus
Copy link

defijesus commented Sep 25, 2018

I have recently found an unexpected bug in the Sentence Segmentation for the Portuguese language.

Here is the script:

import spacy

nlp = spacy.load('pt')
text = open('texto.txt', 'r', encoding='utf-8').read()
doc = nlp(text)
i = 1

for sent in doc.sents:
	print(i)
	i = i+1
	res = sent.text.encode('utf-8')
	print(res)

Here is the input (3 sentences):

As enfermeiras parteiras admitem abandonar os locais de trabalho caso as negociações do Acordo Coletivo de Trabalho com a tutela falhem, disse hoje à agência Lusa, no Porto, o porta-voz do movimento "Enfermagem Unida", José Azevedo.
Em declarações à margem de uma vigília do movimento criado pelas enfermeiras parteiras de todo o país, que reuniu cerca de 50 profissionais de saúde na Avenida dos Aliados, o também presidente do Sindicato dos Enfermeiros (SE) informou "não se tratar de uma ameaça, mas de algo que fica em suspenso para o caso das negociações falharem".
Este é o movimento das enfermeiras parteiras que descontentes com a forma como as coisas estão a decorrer lutam, como nós, pela inclusão da sua especialidade na carreira que temos estado a negociar", informou o sindicalista.

Here is the output (4 sentences):

1
b'As enfermeiras parteiras admitem abandonar os locais de trabalho caso as negocia\xc3\xa7\xc3\xb5es do Acordo Coletivo de Trabalho com a tutela falhem, disse hoje \xc3\xa0 ag\xc3\xaancia Lusa, no Porto, o porta-voz do movimento "Enfermagem Unida", Jos\xc3\xa9 Azevedo.\n'
2
b'Em declara\xc3\xa7\xc3\xb5es \xc3\xa0 margem de uma vig\xc3\xadlia do movimento criado pelas enfermeiras parteiras de todo o pa\xc3\xads, que reuniu cerca de 50 profissionais de sa\xc3\xbade na Avenida dos'
3
b'Aliados, o tamb\xc3\xa9m presidente do Sindicato dos Enfermeiros (SE) informou "n\xc3\xa3o se tratar de uma amea\xc3\xa7a, mas de algo que fica em suspenso para o caso das negocia\xc3\xa7\xc3\xb5es falharem".\n'
4
b'Este \xc3\xa9 o movimento das enfermeiras parteiras que descontentes com a forma como as coisas est\xc3\xa3o a decorrer lutam, como n\xc3\xb3s, pela inclus\xc3\xa3o da sua especialidade na carreira que temos estado a negociar", informou o sindicalista.'

The substring "Avenida dos Aliados" is being recognised as:
screenshot 2018-09-26 00 46 33

"Avenida dos Aliados" is a place. What should be the desirable output here?

Hope we all can find a solution to this soon as spacy is a great project.

@filipecaixeta
Copy link
Contributor Author

I have recently found an unexpected bug in the Sentence Segmentation for the Portuguese language.

Here is the script:

import spacy

nlp = spacy.load('pt')
text = open('texto.txt', 'r', encoding='utf-8').read()
doc = nlp(text)
i = 1

for sent in doc.sents:
	print(i)
	i = i+1
	res = sent.text.encode('utf-8')
	print(res)

Here is the input (3 sentences):

As enfermeiras parteiras admitem abandonar os locais de trabalho caso as negociações do Acordo Coletivo de Trabalho com a tutela falhem, disse hoje à agência Lusa, no Porto, o porta-voz do movimento "Enfermagem Unida", José Azevedo.
Em declarações à margem de uma vigília do movimento criado pelas enfermeiras parteiras de todo o país, que reuniu cerca de 50 profissionais de saúde na Avenida dos Aliados, o também presidente do Sindicato dos Enfermeiros (SE) informou "não se tratar de uma ameaça, mas de algo que fica em suspenso para o caso das negociações falharem".
Este é o movimento das enfermeiras parteiras que descontentes com a forma como as coisas estão a decorrer lutam, como nós, pela inclusão da sua especialidade na carreira que temos estado a negociar", informou o sindicalista.

Here is the output (4 sentences):

1
b'As enfermeiras parteiras admitem abandonar os locais de trabalho caso as negocia\xc3\xa7\xc3\xb5es do Acordo Coletivo de Trabalho com a tutela falhem, disse hoje \xc3\xa0 ag\xc3\xaancia Lusa, no Porto, o porta-voz do movimento "Enfermagem Unida", Jos\xc3\xa9 Azevedo.\n'
2
b'Em declara\xc3\xa7\xc3\xb5es \xc3\xa0 margem de uma vig\xc3\xadlia do movimento criado pelas enfermeiras parteiras de todo o pa\xc3\xads, que reuniu cerca de 50 profissionais de sa\xc3\xbade na Avenida dos'
3
b'Aliados, o tamb\xc3\xa9m presidente do Sindicato dos Enfermeiros (SE) informou "n\xc3\xa3o se tratar de uma amea\xc3\xa7a, mas de algo que fica em suspenso para o caso das negocia\xc3\xa7\xc3\xb5es falharem".\n'
4
b'Este \xc3\xa9 o movimento das enfermeiras parteiras que descontentes com a forma como as coisas est\xc3\xa3o a decorrer lutam, como n\xc3\xb3s, pela inclus\xc3\xa3o da sua especialidade na carreira que temos estado a negociar", informou o sindicalista.'

The substring "Avenida dos Aliados" is being recognised as:
screenshot 2018-09-26 00 46 33

"Avenida dos Aliados" is a place. What should be the desirable output here?

Hope we all can find a solution to this soon as spacy is a great project.

That's not a bug.
By default spaCy will use dependency parse to segment the sentences.
If you want to split on punctuation you should use sentencizer or a custom rule.

Copy link
Member

@ines ines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ines ines merged commit 6c498f9 into explosion:master Sep 29, 2018
ines added a commit that referenced this pull request Nov 29, 2018
* Create aryaprabhudesai.md (#2681)

* Update _install.jade (#2688)

Typo fix: "models" -> "model"

* Add FAC to spacy.explain (resolves #2706)

* Remove docstrings for deprecated arguments (see #2703)

* When calling getoption() in conftest.py, pass a default option (#2709)

* When calling getoption() in conftest.py, pass a default option

This is necessary to allow testing an installed spacy by running:

  pytest --pyargs spacy

* Add contributor agreement

* update bengali token rules for hyphen and digits (#2731)

* Less norm computations in token similarity (#2730)

* Less norm computations in token similarity

* Contributor agreement

* Remove ')' for clarity (#2737)

Sorry, don't mean to be nitpicky, I just noticed this when going through the CLI and thought it was a quick fix. That said, if this was intention than please let me know.

* added contributor agreement for mbkupfer (#2738)

* Basic support for Telugu language (#2751)

* Lex _attrs for polish language (#2750)

* Signed spaCy contributor agreement

* Added polish version of english lex_attrs

* Introduces a bulk merge function, in order to solve issue #653 (#2696)

* Fix comment

* Introduce bulk merge to increase performance on many span merges

* Sign contributor agreement

* Implement pull request suggestions

* Describe converters more explicitly (see #2643)

* Add multi-threading note to Language.pipe (resolves #2582) [ci skip]

* Fix formatting

* Fix dependency scheme docs (closes #2705) [ci skip]

* Don't set stop word in example (closes #2657) [ci skip]

* Add words to portuguese language _num_words (#2759)

* Add words to portuguese language _num_words

* Add words to portuguese language _num_words

* Update Indonesian model (#2752)

* adding e-KTP in tokenizer exceptions list

* add exception token

* removing lines with containing space as it won't matter since we use .split() method in the end, added new tokens in exception

* add tokenizer exceptions list

* combining base_norms with norm_exceptions

* adding norm_exception

* fix double key in lemmatizer

* remove unused import on punctuation.py

* reformat stop_words to reduce number of lines, improve readibility

* updating tokenizer exception

* implement is_currency for lang/id

* adding orth_first_upper in tokenizer_exceptions

* update the norm_exception list

* remove bunch of abbreviations

* adding contributors file

* Fixed spaCy+Keras example (#2763)

* bug fixes in keras example

* created contributor agreement

* Adding French hyphenated first name (#2786)

* Fix typo (closes #2784)

* Fix typo (#2795) [ci skip]

Fixed typo on line 6 "regcognizer --> recognizer"

* Adding basic support for Sinhala language. (#2788)

* adding Sinhala language package, stop words, examples and lex_attrs.

* Adding contributor agreement

* Updating contributor agreement

* Also include lowercase norm exceptions

* Fix error (#2802)

* Fix error
ValueError: cannot resize an array that references or is referenced
by another array in this way.  Use the resize function

* added spaCy Contributor Agreement

* Add charlax's contributor agreement (#2805)

* agreement of contributor, may I introduce a tiny pl languge contribution (#2799)

* Contributors agreement

* Contributors agreement

* Contributors agreement

* Add jupyter=True to displacy.render in documentation (#2806)

* Revert "Also include lowercase norm exceptions"

This reverts commit 70f4e8a.

* Remove deprecated encoding argument to msgpack

* Set up dependency tree pattern matching skeleton (#2732)

* Fix bug when too many entity types. Fixes #2800

* Fix Python 2 test failure

* Require older msgpack-numpy

* Restore encoding arg on msgpack-numpy

* Try to fix version pin for msgpack-numpy

* Update Portuguese Language (#2790)

* Add words to portuguese language _num_words

* Add words to portuguese language _num_words

* Portuguese - Add/remove stopwords, fix tokenizer, add currency symbols

* Extended punctuation and norm_exceptions in the Portuguese language

* Correct error in spacy universe docs concerning spacy-lookup (#2814)

* Update Keras Example for (Parikh et al, 2016) implementation  (#2803)

* bug fixes in keras example

* created contributor agreement

* baseline for Parikh model

* initial version of parikh 2016 implemented

* tested asymmetric models

* fixed grevious error in normalization

* use standard SNLI test file

* begin to rework parikh example

* initial version of running example

* start to document the new version

* start to document the new version

* Update Decompositional Attention.ipynb

* fixed calls to similarity

* updated the README

* import sys package duh

* simplified indexing on mapping word to IDs

* stupid python indent error

* added code from tensorflow/tensorflow#3388 for tf bug workaround

* Fix typo (closes #2815) [ci skip]

* Update regex version dependency

* Set version to 2.0.13.dev3

* Skip seemingly problematic test

* Remove problematic test

* Try previous version of regex

* Revert "Remove problematic test"

This reverts commit bdebbef.

* Unskip test

* Try older version of regex

* 💫 Update training examples and use minibatching (#2830)

<!--- Provide a general summary of your changes in the title. -->

## Description
Update the training examples in `/examples/training` to show usage of spaCy's `minibatch` and `compounding` helpers ([see here](https://spacy.io/usage/training#tips-batch-size) for details). The lack of batching in the examples has caused some confusion in the past, especially for beginners who would copy-paste the examples, update them with large training sets and experienced slow and unsatisfying results.

### Types of change
enhancements

## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.

* Visual C++ link updated (#2842) (closes #2841) [ci skip]

* New landing page

* Add contribution agreement

* Correcting lang/ru/examples.py (#2845)

* Correct some grammatical inaccuracies in lang\ru\examples.py; filled Contributor Agreement

* Correct some grammatical inaccuracies in lang\ru\examples.py

* Move contributor agreement to separate file

* Set version to 2.0.13.dev4

* Add Persian(Farsi) language support (#2797)

* Also include lowercase norm exceptions

* Remove in favour of https://github.com/explosion/spaCy/graphs/contributors

* Rule-based French Lemmatizer (#2818)

<!--- Provide a general summary of your changes in the title. -->

## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include the
issue number. If your PR is still a work in progress, that's totally fine – just
include a note to let us know. -->

Add a rule-based French Lemmatizer following the english one and the excellent PR for [greek language optimizations](#2558) to adapt the Lemmatizer class.

### Types of change
<!-- What type of change does your PR cover? Is it a bug fix, an enhancement
or new feature, or a change to the documentation? -->

- Lemma dictionary used can be found [here](http://infolingu.univ-mlv.fr/DonneesLinguistiques/Dictionnaires/telechargement.html), I used the XML version.
- Add several files containing exhaustive list of words for each part of speech 
- Add some lemma rules
- Add POS that are not checked in the standard Lemmatizer, i.e PRON, DET, ADV and AUX
- Modify the Lemmatizer class to check in lookup table as a last resort if POS not mentionned
- Modify the lemmatize function to check in lookup table as a last resort
- Init files are updated so the model can support all the functionalities mentioned above
- Add words to tokenizer_exceptions_list.py in respect to regex used in tokenizer_exceptions.py

## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [X] I have submitted the spaCy Contributor Agreement.
- [X] I ran the tests, and all new and existing tests passed.
- [X] My changes don't require a change to the documentation, or if they do, I've added all required information.

* Set version to 2.0.13

* Fix formatting and consistency

* Update docs for new version [ci skip]

* Increment version [ci skip]

* Add info on wheels [ci skip]

* Adding "This is a sentence" example to Sinhala (#2846)

* Add wheels badge

* Update badge [ci skip]

* Update README.rst [ci skip]

* Update murmurhash pin

* Increment version to 2.0.14.dev0

* Update GPU docs for v2.0.14

* Add wheel to setup_requires

* Import prefer_gpu and require_gpu functions from Thinc

* Add tests for prefer_gpu() and require_gpu()

* Update requirements and setup.py

* Workaround bug in thinc require_gpu

* Set version to v2.0.14

* Update push-tag script

* Unhack prefer_gpu

* Require thinc 6.10.6

* Update prefer_gpu and require_gpu docs [ci skip]

* Fix specifiers for GPU

* Set version to 2.0.14.dev1

* Set version to 2.0.14

* Update Thinc version pin

* Increment version

* Fix msgpack-numpy version pin

* Increment version

* Update version to 2.0.16

* Update version [ci skip]

* Redundant ')' in the Stop words' example (#2856)

<!--- Provide a general summary of your changes in the title. -->

## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include the
issue number. If your PR is still a work in progress, that's totally fine – just
include a note to let us know. -->

### Types of change
<!-- What type of change does your PR cover? Is it a bug fix, an enhancement
or new feature, or a change to the documentation? -->

## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [ ] I have submitted the spaCy Contributor Agreement.
- [ ] I ran the tests, and all new and existing tests passed.
- [ ] My changes don't require a change to the documentation, or if they do, I've added all required information.

* Documentation improvement regarding joblib and SO (#2867)

Some documentation improvements

## Description
1. Fixed the dead URL to joblib
2. Fixed Stack Overflow brand name (with space)

### Types of change
Documentation

## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.

* raise error when setting overlapping entities as doc.ents (#2880)

* Fix out-of-bounds access in NER training

The helper method state.B(1) gets the index of the first token of the
buffer, or -1 if no such token exists. Normally this is safe because we
pass this to functions like state.safe_get(), which returns an empty
token. Here we used it directly as an array index, which is not okay!

This error may have been the cause of out-of-bounds access errors during
training. Similar errors may still be around, so much be hunted down.
Hunting this one down took a long time...I printed out values across
training runs and diffed, looking for points of divergence between
runs, when no randomness should be allowed.

* Change PyThaiNLP Url (#2876)

* Fix missing comma

* Add example showing a fix-up rule for space entities

* Set version to 2.0.17.dev0

* Update regex version

* Revert "Update regex version"

This reverts commit 62358dd.

* Try setting older regex version, to align with conda

* Set version to 2.0.17

* Add spacy-js to universe [ci-skip]

* Add spacy-raspberry to universe (closes #2889)

* Add script to validate universe json [ci skip]

* Removed space in docs + added contributor indo (#2909)

* - removed unneeded space in documentation

* - added contributor info

* Allow input text of length up to max_length, inclusive (#2922)

* Include universe spec for spacy-wordnet component (#2919)

* feat: include universe spec for spacy-wordnet component

* chore: include spaCy contributor agreement

* Minor formatting changes [ci skip]

* Fix image [ci skip]

Twitter URL doesn't work on live site

* Check if the word is in one of the regular lists specific to each POS (#2886)

* 💫 Create random IDs for SVGs to prevent ID clashes (#2927)

Resolves #2924.

## Description
Fixes problem where multiple visualizations in Jupyter notebooks would have clashing arc IDs, resulting in weirdly positioned arc labels. Generating a random ID prefix so even identical parses won't receive the same IDs for consistency (even if effect of ID clash isn't noticable here.)

### Types of change
bug fix

## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.

* Fix typo [ci skip]

* fixes symbolic link on py3 and windows (#2949)

* fixes symbolic link on py3 and windows
during setup of spacy using command
python -m spacy link en_core_web_sm en
closes #2948

* Update spacy/compat.py

Co-Authored-By: cicorias <[email protected]>

* Fix formatting

* Update universe [ci skip]

* Catalan Language Support (#2940)

* Catalan language Support

* Ddding Catalan to documentation

* Sort languages alphabetically [ci skip]

* Update tests for pytest 4.x (#2965)

<!--- Provide a general summary of your changes in the title. -->

## Description
- [x] Replace marks in params for pytest 4.0 compat ([see here](https://docs.pytest.org/en/latest/deprecations.html#marks-in-pytest-mark-parametrize))
- [x] Un-xfail passing tests (some fixes in a recent update resolved a bunch of issues, but tests were apparently never updated here)

### Types of change
<!-- What type of change does your PR cover? Is it a bug fix, an enhancement
or new feature, or a change to the documentation? -->

## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.

* Fix regex pin to harmonize with conda (#2964)

* Update README.rst

* Fix bug where Vocab.prune_vector did not use 'batch_size' (#2977)

Fixes #2976

* Fix typo

* Fix typo

* Remove duplicate file

* Require thinc 7.0.0.dev2

Fixes bug in gpu_ops that would use cupy instead of numpy on CPU

* Add missing import

* Fix error IDs

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature requests and improvements lang / pt Portuguese language data and models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants