Skip to content

Conversation

@svlandeg
Copy link
Contributor

Description

  • macos-latest is now ARM64, but we were forcefully setting x86. Always build for the native platform instead.
  • Update setup classifiers to include support for Python 3.12 (which was already present)

Types of change

CI fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the tests New, missing or incorrect tests label Apr 29, 2024
@svlandeg svlandeg marked this pull request as ready for review April 29, 2024 08:17
@svlandeg svlandeg merged commit 6d6c10a into explosion:master Apr 29, 2024
@svlandeg svlandeg deleted the fix/ci branch April 29, 2024 08:18
This was referenced Apr 29, 2024
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 3, 2024
* Remove hardcoded architecture setting

* update classifiers to include Python 3.12
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 21, 2024
* Remove hardcoded architecture setting

* update classifiers to include Python 3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests New, missing or incorrect tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant