Increase test deadline to 30 minutes to prevent spurious test failures #11070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@explosion-bot please test_slow_gpu |
Collaborator
URL: https://buildkite.com/explosion-ai/spacy-slow-gpu-tests/builds/60 |
svlandeg
approved these changes
Jul 4, 2022
polm
pushed a commit
that referenced
this pull request
Jul 11, 2022
#11070) * Increase test deadline to 30 minutes to prevent spurious test failures * Reduce deadline to 2 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Occasionally, we have spurious test failures caused by a test iteration/run taking too long to execute and running afoul of the default, arbitrary deadline of 200ms. This PR raises the deadline significantly for all tests to eliminate this particular kind of test failure.
Thinc companion PR - explosion/thinc#714
Types of change
Tests
Checklist