Parser: use C saxpy/sgemm provided by the Ops implementation #10773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of explosion#10747 from the parser refactor branch. It eliminates the explicit calls to BLIS, instead using the saxpy/sgemm provided by the Ops implementation. This allows us to use Accelerate in the parser on M1 Macs (with an updated thinc-apple-ops). Performance of the de_core_news_lg pipe: BLIS 0.7.0, no thinc-apple-ops: 6385 WPS BLIS 0.7.0, thinc-apple-ops: 36455 WPS BLIS 0.9.0, no thinc-apple-ops: 19188 WPS BLIS 0.9.0, thinc-apple-ops: 36682 WPS This PR, thinc-apple-ops: 38726 WPS Performance of the de_core_news_lg pipe (only tok2vec -> parser): BLIS 0.7.0, no thinc-apple-ops: 13907 WPS BLIS 0.7.0, thinc-apple-ops: 73172 WPS BLIS 0.9.0, no thinc-apple-ops: 41576 WPS BLIS 0.9.0, thinc-apple-ops: 72569 WPS This PR, thinc-apple-ops: 87061 WPS
danieldk
added
enhancement
svlandeg
reviewed
May 17, 2022
svlandeg
approved these changes
May 18, 2022
Contributor
Author
|
No more draft, this should work now with Richard's typing PR merged. |
shadeMe
approved these changes
May 25, 2022
Contributor
shadeMe
left a comment
shadeMe
left a comment
There was a problem hiding this comment.
LGTM with just one minor nitpick.
Co-authored-by: Madeesh Kannan <[email protected]>
Contributor
Author
|
@explosion-bot please test_gpu |
Collaborator
URL: https://buildkite.com/explosion-ai/spacy-gpu-test-suite/builds/81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #10747 from the parser refactor branch. It eliminates the explicit calls to BLIS, instead using the saxpy/sgemm provided by the Ops implementation.
This allows us to use Accelerate in the parser on M1 Macs (with an updated thinc-apple-ops).
Performance of the
de_core_news_lgpipe:Performance of the
de_core_news_lgpipe (onlytok2vec -> parser):Types of change
Enhancement, performance improvement.
Checklist