Fix: Always include selected options at the top of the list #2066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on inside to make this works but as an isolated change, it seems (so far) to do the trick.
✅ Deploy Preview for graphweaver-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug I introduced last week. In trying to fix some other issues, I got rid of the separate piece of code that was rendering the selected options, and instead relied on sorting the existing options to bump the selected ones to the top of the list. This was fine, if the selected values in a dropdown with dynamically fetched options appeared in the first set of results fetched.
I've also shuffled and split the UI tests I wrote. One is being strangely flaky at the moment; the sequence of arrow key presses in the test seems to result in different options being selected each time. I've relaxed that test a bit to just assert that something starting with an 'A' gets selected.