Feature / Relationship Filters and Fields infinite scroll + search #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Use this from the relationship filter.
…a. This is needed because setting offset or limit shouldn't return the same result as before.
…s relationship filters. Simplified state management for consumers of the combo box.
✅ Deploy Preview for graphweaver-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
… for selected items.
…o, as that's what we've run our tests on. When we upgrade MikroORM in our monorepo, then that should flow to generated projects. This will stop users experiencing breakages from untested versions of Mikro unless they explicitly upgrade at least.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
likeorilike%${query}%depending on whether you've set it to case insensitive or not. To make this performant it's recommended to use trigram indexes on these fields, or to only enable on small datasets.This should resolve issues loading large amounts of related data in the dropdowns for relationships and gives developers more options to customise the admin UI for large datasets.
In addition, while working on this I resolved the following:
"6"in the peer dependencies. The latest version of Mikro is breaking things for us, and users shouldn't get the absolute latest version of Mikro out of the box unless we've tested it. Our generated project now uses the exact version we used in CI to test, so we know they'll get a working experience out of the box at least. If they then upgrade to a more recent version and that breaks things, that's cool, we will work on fixing it, but at least that's not their out of the box experience.