Skip to content

Fix / Introspection of entities with only single primary key #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

Fix / Introspection of entities with only single primary key #1822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af15f00
Allowed peer dependencies to sort alphabetically.
thekevinbrown Jun 30, 2025
734f3f0
Added special case for when an entity only has a single primary key f…
thekevinbrown Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/packages/mikroorm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
"reflect-metadata": "0.2.2"
},
"peerDependencies": {
"graphql": "16",
"@mikro-orm/core": "6",
"@mikro-orm/knex": "6"
"@mikro-orm/knex": "6",
"graphql": "16"
},
"devDependencies": {
"@mikro-orm/core": "6.4.16",
Expand Down
14 changes: 12 additions & 2 deletions src/packages/mikroorm/src/introspection/files/schema-entity-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import type {
Platform,
} from '@mikro-orm/core';
import { ReferenceKind, Utils } from '@mikro-orm/core';

import pluralize from 'pluralize';
import { identifierForEnumValue, pascalToCamelCaseString, pascalToKebabCaseString } from '../utils';
import { BaseFile } from './base-file';
Expand Down Expand Up @@ -103,7 +102,18 @@ export class SchemaEntityFile extends BaseFile {
}

this.coreImports.add('Entity');
file += `@Entity<${this.meta.className}>(${this.quote(this.meta.className)}, {\n\tprovider: new MikroBackendProvider(Orm${this.meta.className}, connection, { backendDisplayName: '${friendlyNameForDatabaseType(this.databaseType)}' }),\n})\n`;

file += `@Entity<${this.meta.className}>(${this.quote(this.meta.className)}, {\n\tprovider: new MikroBackendProvider(Orm${this.meta.className}, connection, { backendDisplayName: '${friendlyNameForDatabaseType(this.databaseType)}'})`;

if (props.length === 1 && props[0].primary) {
// Special case. If there's a single primary key field in this entity, right now that requires that it's a client side generated primary key.
// There's no reason this has to be the case, but it's a current limitation, so we should generate a working project for them.
// We should be able to remove this in the future and allow users to use it both ways.
file += `,\n\tapiOptions: { clientGeneratedPrimaryKeys: true },\n})\n`;
} else {
file += `\n})\n`;
}

file += `export class ${this.meta.className} {\n`;
file += `${classBody}}\n`;
const imports = [
Expand Down
Loading