Bug/filter bar query fixes #1806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphweaver-storybook-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Only thing I think we should do is remove this comment from // @todo - currently the filters are not fitting on the screen
// we plan to redo this filter bar so that it is a drop downNow that that's resolved. 👍 |
thekevinbrown
approved these changes
Jun 13, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to filtering capabilities, improves the
DatePickercomponent's popup positioning, and refines UI styling across several components. The most significant changes include adding advanced filtering options for theArtistschema, implementing dynamic popup positioning in theDatePicker, and improving the layout of theFilterBarcomponent.Filtering Enhancements:
src/examples/sqlite/src/backend/schema/artist.ts: AddedfilterOptionsto thenamefield in theArtistschema, enabling case-insensitive and substring match filtering.DatePickerComponent Improvements:src/packages/admin-ui-components/src/date-picker/component.tsx: Introduced dynamic popup positioning by calculating its position based on the input field's location and handling window resize events to update the popup position. [1] [2] [3]src/packages/admin-ui-components/src/date-picker/component.tsx: Updated the popup styling to use fixed positioning for better alignment and visibility.src/packages/admin-ui-components/src/date-picker/styles.module.css: Removed absolute positioning from the.popupclass and adjusted padding for improved appearance. [1] [2]FilterBarComponent Enhancements:src/packages/admin-ui-components/src/filter-bar/component.tsx: Removed the restriction on the number of filters displayed and restructured the layout to include scrollable filter components, an icon, and a "Clear Filters" button. [1] [2]Minor Adjustments:
src/packages/admin-ui-components/src/filters/text-filter.tsx: Replaced thenameprop withfieldNamein theTextFiltercomponent for better clarity and consistency.