Feature: storybook setup #1800
Merged
Feature: storybook setup #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request integrates Storybook into the admin-ui-components package and introduces new component stories and configurations to enhance development workflows. Key changes include:
- Adding Storybook configuration files (.storybook/main.ts, preview.ts, manager.ts, theme.ts) and updating ESLint to support Storybook.
- Creating MDX and Story files for components including ComboBox, Checkbox, Card, Button, and Alert.
- Updating package.json with new Storybook-related scripts and dependencies.
Reviewed Changes
Copilot reviewed 111 out of 111 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/packages/admin-ui-components/src/combo-box/combo-box.mdx | Added MDX documentation and example usage for ComboBox. |
| src/packages/admin-ui-components/src/checkbox/checkbox.stories.tsx | Introduced multiple Storybook stories for the Checkbox component. |
| src/packages/admin-ui-components/src/checkbox/checkbox.mdx | Provided MDX documentation for the Checkbox component. |
| src/packages/admin-ui-components/src/card/styles.module.css | Defined styling for the new Card component. |
| src/packages/admin-ui-components/src/card/index.ts | Re-exported the Card component. |
| src/packages/admin-ui-components/src/card/component.tsx | Implemented the Card component with title, description, and children. |
| src/packages/admin-ui-components/src/card/card.stories.tsx | Added several Storybook stories demonstrating various Card component states. |
| src/packages/admin-ui-components/src/card/card.mdx | Created MDX documentation for the Card component. |
| src/packages/admin-ui-components/src/button/button.stories.tsx | Provided Storybook stories for the Button component. |
| src/packages/admin-ui-components/src/button/button.mdx | Added MDX documentation and examples for the Button component. |
| src/packages/admin-ui-components/src/alert/alert.stories.ts | Introduced Storybook stories for the Alert component. |
| src/packages/admin-ui-components/src/alert/alert.mdx | Created MDX documentation and usage guidelines for the Alert component. |
| src/packages/admin-ui-components/package.json | Updated scripts and dependencies for Storybook integration. |
| src/packages/admin-ui-components/.storybook/theme.ts | Configured a custom dark theme for Storybook. |
| src/packages/admin-ui-components/.storybook/preview.ts | Set global preview parameters and imported main CSS for Storybook. |
| src/packages/admin-ui-components/.storybook/manager.ts | Configured the Storybook manager to use the custom theme. |
| src/packages/admin-ui-components/.storybook/main.ts | Defined Storybook configuration with story and addon paths. |
| src/packages/admin-ui-components/.storybook/main.css | Added global CSS for consistent Storybook styling. |
| src/packages/admin-ui-components/.eslintrc.cjs | Extended ESLint configuration to include the Storybook plugin. |
| src/.gitignore | Updated to exclude Storybook log files. |
Co-authored-by: Copilot <[email protected]>
…nology/graphweaver into feature/docs-website
twestos
commented
May 19, 2025
thekevinbrown
previously requested changes
May 19, 2025
Co-authored-by: Kevin Brown <[email protected]>
❌ Deploy Preview for graphweaver-storybook-staging failed. Why did it fail? →
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
✅ Deploy Preview for graphweaver-storybook-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
twestos
dismissed
thekevinbrown’s stale review
Have changes, this prompt for requested changes doesn't seem to be going away. Either that or I'm a github boomer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces Storybook integration into the
admin-ui-componentspackage, along with new components and their associated stories and styles. It also updates dependencies and configurations to support Storybook and improve development workflows.Storybook Integration and Configuration:
main.ts,preview.ts,manager.ts,theme.ts) to enable Storybook in theadmin-ui-componentspackage. These include custom theming and essential addons for improved developer experience. [1] [2] [3] [4].eslintrc.cjsto include the Storybook plugin for linting Storybook-specific files.storybookandbuild-storybookscripts topackage.jsonfor running and building Storybook, respectively.package.jsondependencies and devDependencies to include Storybook-related packages and other required libraries. [1] [2] [3]Component Stories and Documentation:
Alert,Button, andCardcomponents to document their usage, properties, and examples in Storybook. These include interactive controls and guidelines for accessibility. [1] [2] [3] [4] [5] [6]New Card Component:
Cardcomponent with support for title, description, and customizable content. Added styles for consistent visual appearance. [1] [2] [3]Miscellaneous:
.gitignoreto exclude*storybook.logfiles generated during Storybook usage.main.css) for consistent styling across Storybook stories.