-
Notifications
You must be signed in to change notification settings - Fork 219
✨ NEW: Add Docutils MyST config and CLI #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chrisjsewell
merged 17 commits into
executablebooks:master
from
cpitclaudel:docutils_conf
Dec 11, 2021
Merged
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
320f9b1
👌 IMPROVE: Support configuration through docutils.conf
cpitclaudel 46aa23f
👌 IMPROVE: Add a command-line entry point in _docutils.py
cpitclaudel be40bf7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2eae526
Merge branch 'master' into docutils_conf
chrisjsewell 25c8e7f
Add CLI entry-points and help strings
chrisjsewell 4900009
improve
chrisjsewell fee3f88
Update docutils_renderer.py
chrisjsewell 015c452
Add tests
chrisjsewell 6462de4
improve
chrisjsewell db79afc
update
chrisjsewell 3e3c2e2
Update test_docutils.py
chrisjsewell 8ffb92f
Update test_docutils.py
chrisjsewell 90a4e8f
Update test_docutils.py
chrisjsewell 30ba7d7
Add sphinx-build test for including myst in rst
chrisjsewell 34322ce
Add documentation
chrisjsewell f08e0e1
remove delattr
chrisjsewell 2782088
Merge branch 'master' into docutils_conf
chrisjsewell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpitclaudel why do you need to delete the setting here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(note here I made the getting/deleting optional, since if you include a MyST file from an RST file, the MyST settings will not have been loaded)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forget the details :/ I think it was to avoid namespace pollution? I'm guessing I was worried about having the settings both directly in the document under
myst_*and in a config object, so I was planning to remove all themyst_*settings fromdocument.settingsand instead have a single objectdocument.settings.myst_config.Of course, this explanation would make more sense if I had then actually stored the config object as
document.settings.myst_config, but the code doesn't seem to do that, so either I forgot or my guess above is wrong ^^There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll remove it for now then, as it doesn't appear to break anything