Skip to content

[DO-567] Change logic of setting ToC#37

Merged
d0rich merged 2 commits intomasterfrom
36-toc-disappears-in-production
Jun 29, 2023
Merged

[DO-567] Change logic of setting ToC#37
d0rich merged 2 commits intomasterfrom
36-toc-disappears-in-production

Conversation

@d0rich
Copy link
Copy Markdown
Contributor

@d0rich d0rich commented Jun 27, 2023

Now ToC is setup inside Vue lifecycle hooks + watcher for documentation page data.

I built production version locally, and it looks like it works.

@d0rich d0rich added the bug Something isn't working label Jun 27, 2023
@d0rich d0rich requested review from Hdd87 and StanG4313 June 27, 2023 11:44
@d0rich d0rich self-assigned this Jun 27, 2023
@d0rich d0rich linked an issue Jun 27, 2023 that may be closed by this pull request
Hdd87
Hdd87 previously approved these changes Jun 27, 2023
Copy link
Copy Markdown
Contributor

@StanG4313 StanG4313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToC appearing as they suppose to do it
Let's merge and check if it works in production

@lingvolab lingvolab changed the title Change logic of setting ToC [DO-567] Change logic of setting ToC Jun 28, 2023
@d0rich d0rich merged commit 51e390e into master Jun 29, 2023
@d0rich d0rich deleted the 36-toc-disappears-in-production branch June 29, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ToC disappears in production

3 participants