Skip to content

Conversation

@hugo-dc
Copy link
Member

@hugo-dc hugo-dc commented Nov 19, 2019

According to this issue: #22
This PR adds the EVM benchmarking scripts and separates the VM's in different Docker files.

@chfast @cdetrio please let me know if you have any comment

@lgtm-com
Copy link

lgtm-com bot commented Nov 19, 2019

This pull request introduces 4 alerts when merging 5a84a71 into b9a9338 - view on LGTM.com

new alerts:

  • 4 for Unused import

@hugo-dc hugo-dc marked this pull request as ready for review November 21, 2019 22:59
@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2019

This pull request introduces 4 alerts when merging 61af855 into b9a9338 - view on LGTM.com

new alerts:

  • 4 for Unused import

Copy link
Collaborator

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good start (assuming all this works).

Please add

Co-authored-by: cdetrio <[email protected]>

To the commit message.

@chfast
Copy link
Collaborator

chfast commented Nov 22, 2019

Please check the LGTM warnings.

@hugo-dc hugo-dc force-pushed the add-scripts branch 2 times, most recently from 6441dd8 to 08fe4de Compare November 26, 2019 18:35
@lgtm-com
Copy link

lgtm-com bot commented Dec 17, 2019

This pull request introduces 1 alert when merging 4b9825d into b9a9338 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None

@chfast
Copy link
Collaborator

chfast commented Dec 18, 2019

Hey @hugo-dc, the ethereum/go-ethereum#20330 has just been merged, so we can use go-ethereum/master now, and any future release of it.

Changes are looking good, I will review the python code in detail later. Still pay attention to LGTM warnings.

Copy link
Collaborator

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Co-authored-by must be separated by single empty line from the commit title.

Build individual Docker images for each evm implementation

Co-authored-by: cdetrio <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Dec 19, 2019

This pull request fixes 2 alerts when merging 4b755d0 into b9a9338 - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary pass
  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Dec 19, 2019

This pull request fixes 2 alerts when merging 3e3a10b into b9a9338 - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary pass
  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Mar 30, 2020

This pull request fixes 2 alerts when merging be534d3 into b9a9338 - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary pass
  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request introduces 1 alert and fixes 2 when merging 033e4ff into b9a9338 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unnecessary pass
  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request introduces 1 alert and fixes 2 when merging aaaf8e1 into b9a9338 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unnecessary pass
  • 1 for Unused local variable

@jwasinger jwasinger merged commit 5837b74 into ewasm:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants