fix: restore maximized window state correctly when loading dialog geometry #1458
Conversation
…metry This change fixes an issue where the statistics dialog would not properly restore its maximized state when reopening. The previous implementation attempted to manually set the window geometry to simulate a maximized state, but this approach was unreliable and didn't properly handle screen boundaries or multi-monitor setups. The fix replaces the manual geometry setting with a proper call to showMaximized() when the dialog is visible, ensuring that Qt's window management correctly handles the maximized state restoration. This provides consistent behavior across different platforms and display configurations. Changes made: - Removed the manual geometry calculation that attempted to simulate maximized state - Added proper isVisible() check before calling showMaximized() to ensure the window is properly initialized - Simplified the maximized state restoration logic to use Qt's built-in functionality
|
Closes #1431 |
|
thank you @ryan-steed-usa ! I didn't use showMaximized() because it didn't work well on Xwayland #1374, I don't remember the problem but I think it didn't restore the state correctly on Wayland. The problem is that showMaximized() fires the event showEvent(), in showEvent() we load again the settings, showMaximized() is called again, and we end up in a loop. One option could be to not override showEvent(), and replace it with show() (I've only tested it on Arch/Wayland and Mint22/Xorg): def showEvent() -> def show() See please if you can reproduce this bug. |
This change modifies the StatsDialog class to use the show() method instead of overriding showEvent(). This resolves a recursion error. Changes made: - Replaced the showEvent() method override with a show() method - Maintained the same functionality including: - Emitting the _shown_trigger signal - Setting window state to active and unminimized - Updating the window title with version information - Removed the event parameter since show() doesn't receive event arguments - Preserved all existing logic for address checking and window title formatting Co-authored-by: Gustavo Iñiguez Goia <[email protected]>
Forgive me. I'd only tested with manually patched 1.7.2 versions, where I cannot reproduce the bug. But I have successfully reproduced the recursion error with master branch builds (1.7.3 candidate) while testing with Archlinux and Ubuntu. I'm guessing that the PyQT6 migration, or Qt6 itself, has manifest the bug? Per your suggestion, I've added a new commit that does resolve the error everywhere I've tested. Let me know if it's acceptable or not. Thanks! |
|
thank you @ryan-steed-usa ! just in time for the next release. |
2 participants
This change fixes an issue where the statistics dialog would not properly restore its maximized state when reopening. The previous implementation attempted to manually set the window geometry to simulate a maximized state, but this approach was unreliable and didn't properly handle screen boundaries or multi-monitor setups.
The fix replaces the manual geometry setting with a proper call to showMaximized() when the dialog is visible, ensuring that Qt's window management correctly handles the maximized state restoration. This provides consistent behavior across different platforms and display configurations.
Changes made:
A potential caveat is that showMaximized() may encounter problems with X11 although the benefit may outweigh the risk to enhance multi-monitor capability and better compensate for desktop resolution changes. More testing is warranted. Patched 1.7.2 seems to work as expected with KDE Plasma 6.5.2 with Wayland, Linux Mint 22.2 Cinnamon 6.4.8, Ubuntu 24.04 with Gnome 46 and Ubuntu 25.04 with Gnome 48.
X11 provides no standard or easy way to get the frame geometry once the window is decorated. Qt solves this problem with nifty heuristics and clever code that works on a wide range of window managers that exist today. Don't be surprised if you find one where QWidget::frameGeometry() returns wrong results though.
Nor does X11 provide a way to maximize a window. QWidget::showMaximized() has to emulate the feature. Its result depends on the result of QWidget::frameGeometry() and the capability of the window manager to do proper window placement, neither of which can be guaranteed.