DEVPROD-26260 Call GitHub Compare API with SHAs instead of labels#9776
Merged
ZackarySantana merged 20 commits intoevergreen-ci:mainfrom Feb 10, 2026
Merged
DEVPROD-26260 Call GitHub Compare API with SHAs instead of labels#9776ZackarySantana merged 20 commits intoevergreen-ci:mainfrom
ZackarySantana merged 20 commits intoevergreen-ci:mainfrom
Conversation
ZackarySantana
changed the title
ZackarySantana
commented
Feb 9, 2026
| @@ -1,412 +1,425 @@ | |||
| { | |||
| "action": "opened", | |||
Contributor
Author
There was a problem hiding this comment.
I replaced the PR in this test file because our github app doesn't have access to baxterthehacker/public-repo (nor should it). This is also more future proof (external repo can go private, renamed, or deleted)
Kimchelly
approved these changes
Feb 9, 2026
| s.Equal(expectedMergeBase, hash) | ||
| }) | ||
|
|
||
| // This test should fail, but it triggers the retry logic which in turn |
Contributor
There was a problem hiding this comment.
But it could succeed one day if we make a conifer repo! 🌲
Contributor
Author
There was a problem hiding this comment.
Very true. TBH this test isn't even testing anything? It was added 7 years ago, and is getting stopped by trying to get an installation token on an undefined repo. I was thinking of just removing it, wdyt?
ZackarySantana
force-pushed
the
DEVPROD-26260
branch
from
6ffda63 to
07fb21f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVPROD-26260
Description
This uses the PR ref rather than label when we use the github compare API with PRs.
Testing
I tested this locally and on staging. I made three different PRs and retried after deploying.
For all three:
evergreen retryafter deploying to see if they got the new merge base.I also printed out the difference between the ref and sha here in case anyone was interested.
For example, this PR.
Before
After
Notice how the github pr commit didn't change (same head commit), but the merge base did.