Only cache responses when the endpoint returns all data at once#1039
Merged
Only cache responses when the endpoint returns all data at once#1039
Conversation
(e.g., joined_rooms, room_members, room_state, pushers, memberships). For endpoints with server-side pagination (e.g., users_media, devices, destination_rooms), skip caching and use the API response directly, Co-Authored-By: Claude Opus 4.6 <[email protected]>
When rooms are deleted from User's View -> Rooms tab, the getManyReference cache for joined_rooms was not being invalidated, causing the table to show outdated data. This fix: - Adds lifecycle callbacks for rooms resource to invalidate joined_rooms cache after delete/deleteMany operations - Handles 404 errors gracefully in getMany for rooms that were deleted but still referenced (returns minimal data instead of throwing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(e.g., joined_rooms, room_members, room_state, pushers, memberships). For endpoints with server-side pagination (e.g., users_media, devices, destination_rooms), skip caching and use the API response directly
Fixes #1038