Re-add raw methods, accept leveldb in constructor, minor fixes#92
Re-add raw methods, accept leveldb in constructor, minor fixes#92
Conversation
holgerd77
left a comment
There was a problem hiding this comment.
One comment to update, rest looks good.
holgerd77
left a comment
There was a problem hiding this comment.
Looks good now, thanks for the update.
|
@s1na Phew, I am just realizing while scimming through the merged PR history that doing releases on this library got completely lost. 😕 Last release ( Do you think it is still worth to do a pre-TypeScript |
|
@holgerd77 that's not a bad idea actually. It seems this PR is backwards-compatible (this should be tested again though). |
|
I realized I removed the |
tl;dr Changes since the
v3.0.0release had introduced breaking changes (and bugs). This PR makes those changes backwards compatible, and fixes the bugs.ethereumjs-vmpasses all tests without any modifications after integrating this PR.The changes are:
getRaw,putRaw,delRawmethods (but mark them as deprecated)DBobject, instantiate the trie via a leveldb object (like before). This necessitated some other changes incheckpointTrieandsecureTrie.CheckpointTrie._exitCpModewhich passed the wrong object toWriteStreamSecureTrie.copywould copyCheckpointTrie's scratch db and use that as the underlying database, which meant the actual state data wasn't available and this caused quite a few failures.