Conversation
ryanio
force-pushed
the
upgradeTestsToTS
branch
from
4a6ac39 to
5d75653
Compare
|
I added the file renames as a separate commit to try to encourage GitHub to show the files as renamed instead of all deleted and all inserted, but I guess it didn't work for some files 🤷🏻♂️sorry about that, makes the diff really challenging to compare. Let me know if you have suggestions about this. For a better diff view, see just the one commit: Upgrade tests to TS |
holgerd77
left a comment
holgerd77
left a comment
There was a problem hiding this comment.
First look, some questions and clarifications.
| "license": "MPL-2.0", | ||
| "dependencies": { | ||
| "@types/async": "^3.0.8", | ||
| "async": "^2.6.1", |
There was a problem hiding this comment.
We want at some point getting rid of the async dependencies - just as a side note - see issue here ethereumjs/organization#55
There was a problem hiding this comment.
Oops this should be in devDeps, I’ll move it
There was a problem hiding this comment.
Oh, you are right. Already merged, just do a short follow-up PR eventually.
There was a problem hiding this comment.
No prob, will include in next PR for promisify work, hopefully today or tomorrow.
| "dist/**/*" | ||
| ], | ||
| "scripts": { | ||
| "benchmarks": "npm run build && ts-node benchmarks/index.ts", |
There was a problem hiding this comment.
Ah, didn't see this when doing the comment on the benchmark files above.
However this fails for me with a completely fresh node module reinstall with several implicit any type errors. Any comment on that?
There was a problem hiding this comment.
Thanks, I just did a fresh install and ran into the errors, will look at fixing. edit: should be fixed with latest commit now
There was a problem hiding this comment.
Can confirm that this works now.
holgerd77
left a comment
holgerd77
left a comment
There was a problem hiding this comment.
Ok, just skimmed through all the code parts. Most code changes are minor (type additions, syntax updates,..) and pretty much local, think we can very well merge here. Thanks a lot Ryan! 😄
Will directly do the merge.
| const async = require('async') | ||
| import * as async from 'async' | ||
| import * as ethUtil from 'ethereumjs-util' | ||
| const Trie = require('../dist/index.js').BaseTrie |
There was a problem hiding this comment.
Just as a note: benchmarks now moved to be run on dist.
2 participants
This PR:
BufferCallbackandProveCallbackto satisfy implicit type errors in testsnew Buffer()npm run benchmarksfor previously existingbenchmarksfolder