Buffer to Uint8Array conversion

packages/tx/src/eip1559Transaction.ts

@@ -16,7 +16,7 @@ import {
 import { keccak256 } from 'ethereum-cryptography/keccak'
 
 import { BaseTransaction } from './baseTransaction'
-import { AccessLists, checkMaxInitCodeSize } from './util'
+import { AccessLists } from './util'
 
 import type {
   AccessList,
@@ -195,11 +195,6 @@ export class FeeMarketEIP1559Transaction extends BaseTransaction<FeeMarketEIP155
     this._validateYParity()
     this._validateHighS()
 
-    const createContract = txData.to === undefined || txData.to === null
-    if (createContract && this.common.isActivatedEIP(3860)) {
-      checkMaxInitCodeSize(this.common, this.data.length)
-    }
-
     const freeze = opts?.freeze ?? true
     if (freeze) {
       Object.freeze(this)

packages/tx/src/eip2930Transaction.ts

@@ -16,7 +16,7 @@ import {
 import { keccak256 } from 'ethereum-cryptography/keccak'
 
 import { BaseTransaction } from './baseTransaction'
-import { AccessLists, checkMaxInitCodeSize } from './util'
+import { AccessLists } from './util'
 
 import type {
   AccessList,
@@ -175,10 +175,6 @@ export class AccessListEIP2930Transaction extends BaseTransaction<AccessListEIP2
     this._validateYParity()
     this._validateHighS()
 
-    const createContract = txData.to === undefined || txData.to === null
-    if (createContract && this.common.isActivatedEIP(3860)) {
-      checkMaxInitCodeSize(this.common, this.data.length)
-    }
     const freeze = opts?.freeze ?? true
     if (freeze) {
       Object.freeze(this)

packages/tx/src/eip4844Transaction.ts

@@ -22,7 +22,7 @@ import {
   BlobTransactionType,
   SignedBlobTransactionType,
 } from './types'
-import { AccessLists, blobTxToNetworkWrapperDataFormat, checkMaxInitCodeSize } from './util'
+import { AccessLists, blobTxToNetworkWrapperDataFormat } from './util'
 import { computeVersionedHash } from './utils/blobHelpers'
 
 import type {
@@ -146,11 +146,6 @@ export class BlobEIP4844Transaction extends BaseTransaction<BlobEIP4844Transacti
     this._validateYParity()
     this._validateHighS()
 
-    const createContract = txData.to === undefined || txData.to === null
-    if (createContract && this.common.isActivatedEIP(3860)) {
-      checkMaxInitCodeSize(this.common, this.data.length)
-    }
-
     for (const hash of this.versionedHashes) {
       if (hash.length !== 32) {
         const msg = this._errorMsg('versioned hash is invalid length')

packages/tx/src/legacyTransaction.ts

@@ -133,11 +133,6 @@ export class Transaction extends BaseTransaction<Transaction> {
       }
     }
 
-    const createContract = txData.to === undefined || txData.to === null
-    if (createContract && this.common.isActivatedEIP(3860)) {
-      checkMaxInitCodeSize(this.common, this.data.length)
-    }
-
     const freeze = opts?.freeze ?? true
     if (freeze) {
       Object.freeze(this)

packages/tx/test/eip3860.spec.ts

@@ -16,7 +16,7 @@ const addressZero = Address.zero()
 
 tape('[EIP3860 tests]', function (t) {
   t.test('Should instantiate create txs with MAX_INITCODE_SIZE', (st) => {
-    const data = Buffer.alloc(Number(maxInitCodeSize))
+    const data = new Uint8Array(Number(maxInitCodeSize))
     for (const txType of txTypes) {
       try {
         TransactionFactory.fromTxData({ data, type: txType }, { common })
@@ -29,7 +29,7 @@ tape('[EIP3860 tests]', function (t) {
   })
 
   t.test('Should instantiate txs with MAX_INITCODE_SIZE data', (st) => {
-    const data = Buffer.alloc(Number(maxInitCodeSize))
+    const data = new Uint8Array(Number(maxInitCodeSize))
     for (const txType of txTypes) {
       try {
         TransactionFactory.fromTxData({ data, type: txType, to: addressZero }, { common })
@@ -42,7 +42,7 @@ tape('[EIP3860 tests]', function (t) {
   })
 
   t.test('Should not instantiate create txs with MAX_INITCODE_SIZE+1 data', (st) => {
-    const data = Buffer.alloc(Number(maxInitCodeSize) + 1)
+    const data = new Uint8Array(Number(maxInitCodeSize) + 1)
     for (const txType of txTypes) {
       try {
         TransactionFactory.fromTxData({ data, type: txType }, { common })
@@ -55,7 +55,7 @@ tape('[EIP3860 tests]', function (t) {
   })
 
   t.test('Should instantiate txs with MAX_INITCODE_SIZE+1 data', (st) => {
-    const data = Buffer.alloc(Number(maxInitCodeSize) + 1)
+    const data = new Uint8Array(Number(maxInitCodeSize) + 1)
     for (const txType of txTypes) {
       try {
         TransactionFactory.fromTxData({ data, type: txType, to: addressZero }, { common })
@@ -70,7 +70,7 @@ tape('[EIP3860 tests]', function (t) {
   tape(
     'Should allow txs with MAX_INITCODE_SIZE+1 data if allowUnlimitedInitCodeSize is active',
     (st) => {
-      const data = Buffer.alloc(Number(maxInitCodeSize) + 1)
+      const data = new Uint8Array(Number(maxInitCodeSize) + 1)
       for (const txType of txTypes) {
         try {
           TransactionFactory.fromTxData(
@@ -87,7 +87,7 @@ tape('[EIP3860 tests]', function (t) {
   )
 
   tape('Should charge initcode analysis gas is allowUnlimitedInitCodeSize is active', (st) => {
-    const data = Buffer.alloc(Number(maxInitCodeSize))
+    const data = new Uint8Array(Number(maxInitCodeSize))
     for (const txType of txTypes) {
       const eip3860ActiveTx = TransactionFactory.fromTxData(
         { data, type: txType },