TSLint not invoked on lint cli

[s1na]

It has happened a few times for me that running npm run lint returns no error, but running npm run tslint does return errors, which is strange given that lint runs tslint internally.

[holgerd77]

I would generally find it good if these lint and prettier commands would be a bit more verbose. A bit too much auto-magic for my taste. 😋

[holgerd77]

Might this be related to the problems in the merkle-patricia-tree library addressed here?

[s1na]

Hm, I think that might be it! TSLint probably ignores files in `.gitignore`!

…

On Wed, 6 Mar 2019, 13:27 Holger Drewes, ***@***.***> wrote: Might this be related to the problems in the merkle-patricia-tree library addressed here <ethereumjs/merkle-patricia-tree#83 (review)> ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABhJVzeHgShtxN4cvAurHJuv6OXNo8uWks5vT7QwgaJpZM4bHnPh> .

[holgerd77]

Ok, think I will close this here for now, can always reopen if necessary. 😄

[s1na]

This issue still persists, and is not due to .gitignore. npm run lint is not really invoking tslint.

[alcuadrado]

Where do you see this issue? In which projects?

[s1na]

I noticed in while working on turbo-token, but just tested in VM and it's the same.

[krzkaczor]

Can u provide a CI build link?

[s1na]

From https://circleci.com/gh/ethereumjs/ethereumjs-vm/7322:

#!/bin/bash -eo pipefail
npm run lint

> ethereumjs-vm@4.1.0 lint /home/circleci/project/ethereumjs-vm
> ethereumjs-config-lint

+ exec npm run format

> ethereumjs-vm@4.1.0 format /home/circleci/project/ethereumjs-vm
> ethereumjs-config-format

+ exec prettier --list-different **/*.{ts,json,md}