This repository was archived by the owner on Nov 5, 2020. It is now read-only.
Conversation
Member
Author
|
Ah, and I tested both the failure and (obvious 😄) the success case. |
This was referenced Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple
pre-pushGit hook using theHuskypackage as suggested in ethereumjs/ethereumjs-config#16.This works like a charm 🙏 🎊 - I am already in love - since it will prevent many future double-rounds on community and non-community commits.
I have a tendency to just only add linting - since it is by far the most common cause of initial CI failure - and not add testing, since this might be annoying or limiting at times. Think with linting we are already a lot far better off.
This is an exemplary first appliance, I would go through the other repos and do the integration together with some other work for practicality once this is approved.