Skip to content

Conversation

@marioevz marioevz force-pushed the engine-api-blobs branch 4 times, most recently from 7c7dc52 to 57daae3 Compare June 3, 2023 00:03
@marioevz marioevz force-pushed the engine-api-blobs branch 4 times, most recently from 6e9a8b1 to fc2f040 Compare June 30, 2023 16:47
@fjl
Copy link
Collaborator

fjl commented Jul 18, 2023

About your TODO

Verify the network version of the blob transactions is not returned anywhere (eth_getBlockByNumber, eth_getBlockByHash, etc.)

That should be covered by rpc-compat tests already.

@fjl
Copy link
Collaborator

fjl commented Jul 18, 2023

I see you added devp2p tests. These should be handled by the devp2p simulator instead!

@marioevz marioevz force-pushed the engine-api-blobs branch 3 times, most recently from 70828a0 to c97317b Compare July 28, 2023 17:18
@fjl fjl force-pushed the engine-api-blobs branch from 75f7e17 to e8d8d79 Compare August 1, 2023 15:56
@marioevz marioevz marked this pull request as ready for review August 3, 2023 18:10
@marioevz marioevz changed the title simulators/ethereum/engine: Engine API Blobs simulators/ethereum/engine: Engine API Cancun Aug 3, 2023
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@marioevz marioevz merged commit 6399870 into ethereum:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants