clients/ethrex: add full and snap sync tests. Default to full sync #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mpaulucci
commented
Oct 10, 2025
mpaulucci
commented
- Default to full sync for all the simulations.
- Adds support to test full and snap sync
…r other simulations.
Collaborator
|
I have implemented HIVE_NODETYPE in cfe5f0c |
github-merge-queue bot
pushed a commit
to lambdaclass/ethrex
that referenced
this pull request
Oct 14, 2025
**Motivation** When a Hive job failed, the L1 workflow didn't fail. This is because we started using `ethpandaops/hive-github-action` **Description** - Adds a script to read log files from the Hive jobs and fail if any of the tests failed - Adds the list of failed jobs to the job summary - Uploads the logs of the simulation with the failed Hive tests. - Merged snap and full sync into one simulation (we were testing the same thing twice, this PR should fix it ethereum/hive#1353 Here is an example of a run with failing hive tests: https://github.com/lambdaclass/ethrex/actions/runs/18411165213?pr=4827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.