core, ethdb/leveldb: use min/max/clear #30957
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitglorythegreat
requested review from
holiman and
rjl493456442
as code owners
Member
|
I would prefer not to make changes. While the built-in functions min, max, and clear are indeed more readable, they provide no functional difference. We aim to avoid unnecessary code refactoring to minimize the risk of introducing potential issues. Especially as you mentioned there are lots of codes across different package can be rewritten in the new pattern. Thanks for the contribution, I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #29307
I found many min/max pattern in the code. Do you think it's worthwhile to make additional PRs for different packages to clean code? Could reduce hundreds of lines of code.