feat(eth/tracers): convert OOG wrapped error to Out Of Gas parity error #30497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
s1na
reviewed
Oct 10, 2024
eth/tracers/internal/tracetest/testdata/call_tracer_flat/callcode_precompiled_throw.json
Show resolved
Hide resolved
s1na
reviewed
Oct 14, 2024
s1na
approved these changes
Oct 14, 2024
Contributor
s1na
left a comment
s1na
left a comment
There was a problem hiding this comment.
I think in general it is hard to strive for compatibility on error messages with other clients and it is not something we should shoot for.
However given that out of gas is pretty common and it is under consensus rules I think we can make an exception.
Nmhth17
approved these changes
Nov 2, 2024
GrapeBaBa
pushed a commit
to optimism-java/shisui
that referenced
this pull request
Nov 2, 2024
) Compatible error message in the flat call tracer with parity-style endpoints. Signed-off-by: jsvisa <[email protected]>
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
Compatible error message in the flat call tracer with parity-style endpoints. Signed-off-by: jsvisa <[email protected]>
jakub-freebit
pushed a commit
to fblch/go-ethereum
that referenced
this pull request
Jul 3, 2025
) Compatible error message in the flat call tracer with parity-style endpoints. Signed-off-by: jsvisa <[email protected]>
28 tasks
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
) Compatible error message in the flat call tracer with parity-style endpoints. Signed-off-by: jsvisa <[email protected]>
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 15, 2025
Compatible error message in the flat call tracer with parity-style endpoints. Signed-off-by: jsvisa <[email protected]>
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 15, 2025
Compatible error message in the flat call tracer with parity-style endpoints. Signed-off-by: jsvisa <[email protected]>
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Sep 17, 2025
… (#1499) Compatible error message in the flat call tracer with parity-style endpoints. Signed-off-by: jsvisa <[email protected]> Co-authored-by: Delweng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.