common/math: rename variable name int to in
#29890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
Author
|
Ah, sorry for it. But anyway, using built-in identifier |
karalabe
suggested changes
May 31, 2024
Member
karalabe
left a comment
karalabe
left a comment
There was a problem hiding this comment.
I could agree with replacing with with n, which is used across Go. But in seems arbitrary.
Contributor
Author
|
@karalabe Done |
jorgemmsilva
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Jun 17, 2024
* chore: rename variable name `int` to `in` * chore: rename variable name `int` to `n`
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 28, 2024
* chore: rename variable name `int` to `in` * chore: rename variable name `int` to `n`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's odd to use the keyword
intas variable name, I think it's better to usein