Skip to content

Conversation

@rjl493456442
Copy link
Member

@rjl493456442 rjl493456442 commented May 8, 2024

This pull request pulls the latest changes from tests repo, including the changes for EIP7610 (ethereum/tests#1367)

TODO

  • "tests" are not fully consistent regarding the definition of the fork name. Both "Paris" and "Merge" are used in different places.

@rjl493456442 rjl493456442 added this to the 1.14.2 milestone May 8, 2024
@rjl493456442 rjl493456442 removed this from the 1.14.3 milestone May 9, 2024
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green

GrayGlacierBlock: big.NewInt(0),
},
"Merge": {
"Paris": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this causes a problem, we can just add Merge too, so we have them both

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have told testing guys to unify the test data. I am fine with defining both Merge and Paris to pass the tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed

@rjl493456442 rjl493456442 added this to the 1.14.4 milestone May 13, 2024
@rjl493456442 rjl493456442 merged commit 5b3e3cd into ethereum:master May 13, 2024
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants