core/types: fix unmarshalling of BlobTx values #27939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
requested review from
holiman,
karalabe and
rjl493456442
as code owners
lightclient
force-pushed
the
fix-4844-json
branch
from
2b6d895 to
4a3fe8c
Compare
lightclient
force-pushed
the
fix-4844-json
branch
from
4a3fe8c to
5643072
Compare
lightclient
changed the title
fjl
approved these changes
Aug 16, 2023
fjl
changed the title
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
FromBig returns true *when overflow occurs*
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 93dbe13.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 93dbe13.
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Mar 8, 2024
FromBig returns true *when overflow occurs*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
okshould actually be interpreted asoverflow.