internal/ethapi: add block overrides to eth_call #26414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
requested review from
gballet,
holiman,
karalabe,
rjl493456442 and
zsfelfoldi
as code owners
holiman
reviewed
Jan 12, 2023
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
This requires a proper motivation, explaining why the existing functionality does not cover this usecase
s1na
changed the title
Contributor
Author
|
I've rebased and deleted the |
holiman
approved these changes
Apr 27, 2023
| BaseFee *big.Int | ||
| } | ||
|
|
||
| func (o BlockOverrides) MarshalJSON() ([]byte, error) { |
Contributor
There was a problem hiding this comment.
Did you "generate" this manually?
Contributor
Author
There was a problem hiding this comment.
Yes it's handmade quality :)
| } | ||
|
|
||
| // BlockOverrides specifies the set of header fields to override. | ||
| type BlockOverrides struct { |
Contributor
There was a problem hiding this comment.
Perhaps add a comment that this struct is a direct "replica" of the BlockOverrides defined in interna/ethapi/api.go.
Would it make sense to have it defined in only one place (thus remove it from internal)?
Contributor
Author
There was a problem hiding this comment.
We kinda need both. The API needs fields with suitable types for input (i.e. hexutil), and gethclient needs standard types which will then be serialized to be sent to the API. That's the reason why I copied the structure and changed the types.
Co-authored-by: Martin Holst Swende <[email protected]>
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
Adds an optional config parameter to eth_call which allows users to override block context fields (same functionality that was added to traceCall in ethereum#24871) --------- Co-authored-by: Martin Holst Swende <[email protected]>
holiman
pushed a commit
that referenced
this pull request
Oct 23, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Adds an optional config parameter to eth_call which allows users to override block context fields (same functionality that was added to traceCall in ethereum#24871) --------- Co-authored-by: Martin Holst Swende <[email protected]>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
)" This reverts commit 1c66a6b.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
)" This reverts commit 1c66a6b.
11 tasks
HighGoal1991
added a commit
to HighGoal1991/go-ethereum
that referenced
this pull request
Mar 21, 2024
This update covers this PRs: - ethereum/go-ethereum#26414 - ethereum/go-ethereum#27183 - ethereum/go-ethereum#26291 - ethereum/go-ethereum#26048
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2025
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 13, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 22, 2025
19 tasks
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 22, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 9, 2025
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional config parameter to
eth_callwhich allows users to override block context fields (same functionality that was added totraceCallin #24871)Also I've integrated some of the changes from #25743, specially some test cases and modification to
GetEVM.Fixes #24025.