core: remove old conversion to shuffle leveldb blocks into ancients #22739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Weird. I tried this exact fix (pretty much), and some tests in package core failed for me. |
rjl493456442
approved these changes
Apr 29, 2021
Member
rjl493456442
left a comment
rjl493456442
left a comment
There was a problem hiding this comment.
lgtm.
Perhaps we should consider writing genesis to freezer in other place? For example in the initialization. But it's just the nitpick.
And let's run the fast sync/snap sync/full sync to ensure it's not broken. We don't need to finish the entire sync, but just the beginning.
9 tasks
9 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a loop which we had in place to handle the case where people were upgrading from 1.8 to 1.9 during a fast-sync.
In 1.9, we started shoving old block data immediately into the freezer, whereas previously we wrote it to leveldb first.