eth, eth/tracers: expose gas used in tx to js tracer #22038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth/tracers: include tx gas in tracers usedGas eth/tracers: fix prestate tracer's sender balance eth/tracers: rm unnecessary import eth/tracers: pass intrinsicGas separately to tracer eth/tracers: fix tests broken by lack of txdata eth, eth/tracers: minor fix
s1na
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
approved these changes
Dec 21, 2020
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
LGTM -- I pushed a commit to un-export the struct used in testing, and also added a testcase for some basic sanity-checking of the feature.
Strikes me now though that the tests can be simplified even more...
Contributor
|
Pushed another commit to remove some of the boilerplate |
Contributor
|
Ok, perfection achieved |
holiman
force-pushed
the
gasprice-available-to-vm-tracer
branch
from
18d89f5 to
87dffcf
Compare
9 tasks
9 tasks
This was referenced Sep 23, 2022
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jul 26, 2025
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #21553 (fixes #20537). It exposes two new parameters
gasPriceandintrinsicGasto js tracers. Using these two and the already exposedgasUsedthey can calculate how much the sender spent on gas.