eth/downloader: save the correct delivery time for state sync #21427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2021
9 tasks
Merged
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 9, 2025
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 17, 2025
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jun 19, 2025
…m#21427 (#1044) Co-authored-by: Péter Szilágyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state sync delivery time was accounted as the time the response reached the trie node data processor. But that's wrong, because the processor might be blocked processing a previous response from someone else. That would mean that with enough load on the processor, the delivery times will get pushed more and more out, causing the RTT calculations to be totally off.