[wip] trie: enable Commit for stacktrie #21282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Jul 6, 2020
Comment on lines
+482
to
+484
| d := hasherPoolNoCache.Get().(crypto.KeccakState) | ||
| d.Reset() | ||
| defer hasherPoolNoCache.Put(d) |
Contributor
There was a problem hiding this comment.
As an alternative, you let the outer world provide a hasher, which is reused by this stacktrie. Something like :
hasker := crypto.NewKeccakState()
st := NewStacktrie( hasher)
for {
st.TryUpdate(key, value)
}
h := st.Hash()
Then you wouldn't need the pooling, but you'd instead need to separate between the public StackTrie and the internal stackTrie node representations.
Contributor
|
This can be closed now, I think.. ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.