core/rawdb: avoid O_APPEND #19676
Merged
core/rawdb: avoid O_APPEND #19676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankSzendzielarz
requested review from
holiman,
karalabe and
rjl493456442
as code owners
fjl
reviewed
Jun 6, 2019
fjl
reviewed
Jun 6, 2019
karalabe
reviewed
Jun 7, 2019
| } | ||
|
|
||
| // openFreezerFile opens a freezer table file and seeks to the end | ||
| func openFreezerFileForAppend(filename string) (*os.File, error) { |
Member
There was a problem hiding this comment.
Nitpick, please fix the comments so they reference the correct method (on this and the 2 methods below).
Member
There was a problem hiding this comment.
And in general, please leave an empty space after the // characters within the method comments.
Member
There was a problem hiding this comment.
And please capitalize min-method comments :)
Member
Author
There was a problem hiding this comment.
lol, well spotted. thanks, and done :-)
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes freezer on Windows.
Summary:
The O_APPEND flag in the Go implementation for windows removes the rights to truncate a file.
A workaround was implemented where O_APPEND was avoided, but writes force a Seek to end of file.