Skip to content

cmd/evm: print vm output when debug flag is on. #16326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2018
Merged

cmd/evm: print vm output when debug flag is on. #16326

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a9a6f1
cmd/evm: print vm output when debug flag is on.
Mar 16, 2018
339c13a
core/vm: check debug flag for printing output.
Mar 16, 2018
4635482
main: make structlogger print output correctly
holiman Mar 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/evm/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,10 @@ Gas used: %d
}
if tracer != nil {
tracer.CaptureEnd(ret, initialGas-leftOverGas, execTime, err)
fmt.Printf("0x%x", ret)
Copy link
Contributor

@holiman holiman Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 'proper' solution would be to configure the tracer used to do the printout during CaptureEnd ... it's been a while since i looked at the code, though. Doing it tihs way would cause printing on stdout even if --json flag is used, iiuc, which would break json parsing the output

Copy link
Contributor Author

@dm4 dm4 Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! I'll check debug flag for printing output.

if err != nil {
fmt.Printf(" error: %v\n", err)
}
} else {
fmt.Printf("0x%x\n", ret)
if err != nil {
Expand Down