cmd/faucet: fix removal of Twitter zlib compression #15729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @karalabe ! Any idea when this will get deployed to https://faucet.rinkeby.io/ ? |
Member
Author
|
Should be online now :)
…On Thu, Dec 21, 2017 at 4:08 PM, Józsi ***@***.***> wrote:
Thank you, @karalabe <https://github.com/karalabe> ! Any idea when this
will get deployed to https://faucet.rinkeby.io/ ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15729 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAH6GfelxBpGel9lVnRNHMKhoH11Vauoks5tCmZYgaJpZM4RJvmz>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15645 and #15635.
Twitter in their latest update reworked their HTTP compression, properly doing it now (previously they used some forced zlib compression, even if the client didn't ask for it). This PR updates the faucet to drop the forced zlib decompression too.