p2p/discover: fix leaked goroutine in data expiration #15696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatelmas
force-pushed
the
p2p-goroutine-leak
branch
from
1609eb6 to
8af0f55
Compare
karalabe
reviewed
Dec 18, 2017
p2p/discover/database.go
Outdated
Member
There was a problem hiding this comment.
It's cleaner to do a defer tick.Stop() after creating the ticker. That way the code is simpler and more robust in the face of future changes / multiple return paths.
Contributor
Author
There was a problem hiding this comment.
Right, thank you, pushed.
ferhatelmas
force-pushed
the
p2p-goroutine-leak
branch
from
8af0f55 to
afa3c72
Compare
ferhatelmas
added a commit
to ferhatelmas/go-ethereum
that referenced
this pull request
Dec 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.