Skip to content

Conversation

@jochem-brouwer
Copy link
Member

πŸ—’οΈ Description

This PR adds a mode to the keccak benchmark to ensure that the memory is updated each time keccak is called. This ensures that clients with a caching mechanism cannot use it (we generate a hash chain).

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • Before we merge this, I am confused by the test. The offset seems to place the calldata at an offset in the memory, and then if we hash it, we also start from this offset. So, we actually hash the same, regardless of what the offset parameter is. Is this the intent of this flag? Why is it there? The only thing it changes is that it writes to different memory (and will only do this once at startup). @LouisTsai-Csie maybe knows?

  • Do not merge until we have reviewed the keccak benchmark πŸ˜„ πŸ‘

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.

  • All: Considered adding an entry to CHANGELOG.md.

  • All: Considered updating the online docs in the ./docs/ directory.

  • All: Set appropriate labels for the changes (only maintainers can apply labels).

  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.

  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant