Skip to content

Conversation

@danceratopz
Copy link
Member

🗒️ Description

This PR removes the automatic application of @pytest.mark.pre_alloc_group if a test case is marked as slow.

This removes > 1000 unnecessary pre-alloc groups, which speeds up consume enginex.

⚠️ @spencer-tb perhaps you should tag a release before this gets merged, just in case this causes release generation to time out - after #1804 this shouldn't be a problem.

🔗 Related Issues or PRs

Spotted while testing the enginex simulator:

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md. skipped
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

image

@danceratopz danceratopz added C-bug Category: this is a bug, deviation, or other problem A-test-cli-fill Area: Tests Fill CLI—runs tests and generates fixtures (eg. `p/t/s/e/cli/pytest_commands/fill.py`) labels Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (fa1a2bb) to head (06296b9).
⚠️ Report is 20 commits behind head on forks/osaka.

Additional details and impacted files
@@               Coverage Diff               @@
##           forks/osaka    #1819      +/-   ##
===============================================
- Coverage        86.08%   86.08%   -0.01%     
===============================================
  Files              743      743              
  Lines            44072    44076       +4     
  Branches          3891     3891              
===============================================
+ Hits             37938    37941       +3     
- Misses            5656     5657       +1     
  Partials           478      478              
Flag Coverage Δ
unittests 86.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-cli-fill Area: Tests Fill CLI—runs tests and generates fixtures (eg. `p/t/s/e/cli/pytest_commands/fill.py`) C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant