feat(tests): Add tests for ecadd/ecmul/ecpairing constant gas repricing#1738
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1738 +/- ##
===============================================
- Coverage 86.08% 86.08% -0.01%
===============================================
Files 743 743
Lines 44072 44076 +4
Branches 3891 3891
===============================================
+ Hits 37938 37941 +3
- Misses 5656 5657 +1
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LouisTsai-Csie
approved these changes
Nov 26, 2025
Comment on lines
+41
to
+44
| if fork < Istanbul: | ||
| gas = gas_pre_istanbul | ||
| else: | ||
| gas = gas_post_istanbul |
Collaborator
There was a problem hiding this comment.
Just a nit:
Suggested change
| if fork < Istanbul: | |
| gas = gas_pre_istanbul | |
| else: | |
| gas = gas_post_istanbul | |
| gas = gas_pre_istanbul if fork < Istanbul else gas_post_istanbul |
marioevz
reviewed
Nov 26, 2025
Member
There was a problem hiding this comment.
This test belongs in the byzantium folder IMO.
marioevz
force-pushed
the
tests/bn254
branch
from
6bbf8d4 to
ee85e13
Compare
SamWilsn
pushed a commit
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
The precompiles were repriced in Istanbul. There are legacy tests covering this but are hard to port, while (given static tests) we're only missing pre-istanbul price calculation coverage.
This test fills this gap but doesn't otherwise port the legacy test.
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.