Skip to content

feat(tests): expand *CALL gas testing test#1703

Merged
spencer-tb merged 1 commit into
ethereum:forks/osakafrom
pdobacz:tests/calls
Oct 29, 2025
Merged

feat(tests): expand *CALL gas testing test#1703
spencer-tb merged 1 commit into
ethereum:forks/osakafrom
pdobacz:tests/calls

Conversation

@pdobacz
Copy link
Copy Markdown
Contributor

@pdobacz pdobacz commented Oct 28, 2025

🗒️ Description

Various lines in the call implementation in evmone were reporting as missing coverage - revolving around conditions which trigger OOG on the stages of processing the call.

Here, an almost complete test case existed in EEST, so I took the liberty to extend it, rather than pulling in the gas_test machinery as yet another approach. The existing test got a bit more complicated, but I think still makes sense. I think I've managed to retain the existing test cases intact.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb spencer-tb added the A-test-tests Area: tests for packages/testing label Oct 29, 2025
Copy link
Copy Markdown
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much for adding this :D

@spencer-tb spencer-tb added the C-feat Category: an improvement or new feature label Oct 29, 2025
@spencer-tb spencer-tb merged commit 73571dd into ethereum:forks/osaka Oct 29, 2025
10 of 11 checks passed
@pdobacz pdobacz deleted the tests/calls branch October 29, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-tests Area: tests for packages/testing C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants