all: Abstract fixtures, StateTest refactor #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Accomplishes the first steps to implement a fully functional StateTest generator in execution-spec-tests:
Fixtureinto aBaseFixture, in order to be able to implement a new fixture type, that is StateTestStateTestFixture, depending on the parameters used to run the test filler.specfolder to include a subfolder per test type (at the moment onlyblockchainandstate)FixtureHeader,FixtureExecutionPayload,FixtureEngineNewPayload,FixtureBlockandFixtureintospec/blockchain/types.py, since these types are pertinent only to the BlockchainTest type.At the moment, the functionality and output fixtures are (or should be) unchanged.
Remaining tasks (follow-up PRs):
spec/state/types.pyshould have its ownclass Fixturethat represents an output fixture of the state tests.FixtureCollectorclass so it behaves differently depending on the test type that it's collecting (in my opinion, we should collect only one type per run, so it should panic if it finds two different types, but this is open to discussion)🔗 Related Issues
Towards fixing #343
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.