chore(design-system): remove unused components and stale assets#18134
Open
myelinated-wackerow wants to merge 2 commits intodevfrom
Open
chore(design-system): remove unused components and stale assets#18134myelinated-wackerow wants to merge 2 commits intodevfrom
myelinated-wackerow wants to merge 2 commits intodevfrom
Conversation
Drops a batch of components identified as unused or story-only in the design-system audit (#18131): - AdoptionChart, AreaChart, BarChart (local; remaining usages import from recharts directly), BoxGrid, EthVideo, Layer2ProductCard, RandomAppList, Stat - Banners: UpgradeBannerNotification, EventsOrganizerBanner, DismissableBanner - ui: drawer, buttons/SvgButtonLink, buttons/ButtonTwoLines (and ButtonLinkTwoLines), radio-group (Quiz uses Radix directly) Removes their stories, the orphaned bn/dapps markdown file (the /dapps route redirects to /apps, a React route), the now-orphaned vaul dependency (only consumer was ui/drawer), and a stale TODO in PathButton referencing the removed ButtonLinkTwoLines. Drops the adoption-chart-* keys from the English page-energy-consumption.json (the issue text named the wrong file). Non-English equivalents are removed in a follow-up commit since pipeline manifests for that namespace are not yet in place. Refs #18131 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
Removes the orphaned adoption-chart-* keys from all 24 non-English page-energy-consumption.json files. The owning component (AdoptionChart) was deleted in the prior commit; the namespace has no pipeline manifest yet, so the keys are removed manually here rather than waiting on propagation. Closes #18131 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
myelinated-wackerow
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
content 🖋️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a batch of components flagged as unused or story-only by the design-system audit (#18131).
Components deleted
AdoptionChart,AreaChart,BarChart(local; remaining usages import from recharts directly),BoxGrid,EthVideo,Layer2ProductCard,RandomAppList,StatUpgradeBannerNotification,EventsOrganizerBanner,DismissableBannerdrawer,buttons/SvgButtonLink,buttons/ButtonTwoLines(andButtonLinkTwoLines),radio-group(Quiz uses Radix directly)Other cleanup
*.stories.tsxfilespublic/content/translations/bn/dapps/index.md-- orphaned (the/dapps/route redirects to/apps/, a React route)EventsOrganizerBannerfrom the destructured set insrc/layouts/Static.tsxvauldependency (only consumer wasui/drawer)// TODO: Convert this component to use ButtonLinkTwoLinescomment inSimulator/PathButton.tsxintl
Removes
adoption-chart-*keys frompage-energy-consumption.jsonacross all 25 locales. The issue text mentionedpage-what-is-ethereum.json, but those keys actually lived inpage-energy-consumption.json. The keys are removed across all locales in this PR (rather than relying on pipeline propagation) since the namespace doesn't yet have a pipeline manifest.Test plan
pnpm lintpassesnpx tsc --noEmitpasses (pre-existing image-module errors are unrelated)pnpm buildpasses (verified locally)/en/energy-consumption/renders (only consumer of the removedadoption-chart-*keys was the deletedAdoptionChartcomponent)/en/whitepaper/) renders -- verifies theEventsOrganizerBannerremoval fromstaticComponentsis harmless (no markdown content invokes it; verified via grep)Out of scope
Per the issue, these are intentionally kept:
AB/*,ui/textarea,Faq/. Coordination with PRs #18125, #18126 (story-file removal) handled if/when they merge -- conflicts trivially resolve in this PR's favor.