feat(storybook): expand form input stories#18123
Open
myelinated-wackerow wants to merge 6 commits intodevfrom
Open
feat(storybook): expand form input stories#18123myelinated-wackerow wants to merge 6 commits intodevfrom
myelinated-wackerow wants to merge 6 commits intodevfrom
Conversation
Cover Default, Sizes (`md|sm`), HasError (`true|false`), WithoutPlaceholder, WithHelperText, and Disabled. Title hierarchy `UI / Primitives / Textarea` per #18121. Helper text is rendered as a sibling element with neutral or error tone since `Textarea` does not bundle it natively. Refs: #18121 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
Retitle to `UI / Primitives / Input`. Add HasError, Disabled (with and without value), AutoFocus, and WithHelperText stories. Keep Sizes story focused on the size axis only. Refs: #18121 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
Retitle to `UI / Primitives / Checkbox`. Split the existing kitchen-sink story into focused stories per state: Default, Checked, Indeterminate (new), Disabled, Invalid, and AsGroup composition. Indeterminate addresses the gap called out in #18121. Refs: #18121 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
Retitle to `UI / Primitives / Switch`. Split into focused stories: Off, On, Disabled (off and on), Invalid, WithLabel, and a SettingsList composition. WithLabel and on/off coverage address the gaps called out in #18121. Refs: #18121 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
Retitle to `UI / Primitives / RadioGroup`. Split into focused stories: Default, Disabled (group-wide and per-item), Invalid, TwoItems, FiveItems, and WithDescriptions composition. Item-count variants address the gap called out in #18121. Refs: #18121 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
myelinated-wackerow
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced May 5, 2026
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds and expands Storybook stories for the form input primitives in
src/components/ui/. This is PR 2 of 5 for #18121, scoped to form inputs. One commit per checkbox in the issue.UI / Primitives / Textarea.UI / Primitives / Input.UI / Primitives / Checkbox.UI / Primitives / Switch.The four stories live under
UI / Primitives / [Name]to match the hierarchy established in #18122 (PR 1). Title alignment is intentionally consistent within this cleanup; the team can decide on a final hierarchy in a future pass.Removed
Notes for review
cvavariant shape (size,hasError); the two stories are deliberately structurally similar so designers see the parity at a glance.Checkboxindeterminate state addresses the gap called out in feat(design-system): Add Storybook stories for canonical UI primitives #18121.SwitchWithLabelstory uses nested-label association (nohtmlForneeded);SettingsListmodels a realistic settings-panel use.Test plan
Refs: #18121